fix(3000): Look reasonable on mobile #19262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
thmsobrmlr
approved these changes
Dec 12, 2023
|
Btw I'd love to test this on a real phone (vs browser with dev tools). Do you have a setup that works this way i.e. listens on the Mac's ip instead of localhost? |
|
I found these issues actually using PostHog on mobile, but didn't test the PR on a real device, just the dev tools mobile simulation. But this should be pretty simple if you're using VS Code, you can expose localhost publicly with the "Ports" feature (I think they mostly added it to make Codespaces usable). @thmsobrmlr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The 3000 UI was janky on mobile, with horizontal places in many places, often because of breadcrumbs.
We were also showing keyboard shortcuts even if they couldn't be used:
These problems are now solved.
Overflow of breadcrumbs is still a problem, but for that I'm working on a separate solution that'd also work for long titles on desktop.